[ISSUE #227] Fix inconsistent Broker data across different RocketMQ NameServers. - #228
[ISSUE #227] Fix inconsistent Broker data across different RocketMQ NameServers.#228shangjin92 wants to merge 1 commit into
Conversation
shangjin92
commented
May 8, 2024
shangjin92
commented
- fix Inconsistent Broker data retrieved from different RocketMQ NameServers. #227
- Refactor ReconcileBroker by extracting EnsureBrokerStatefulSets method.
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #228 — [ISSUE #227] Fix inconsistent Broker data across different NameServers
Type: Bug fix (1 file, +55/-31)
Assessment
Fixes data inconsistency issue where broker information could differ across NameServers. Also refactors ReconcileBroker by extracting EnsureBrokerStatefulSets method for better code organization.
Verdict
✅ Important bug fix with clean refactoring. Addresses a real data consistency concern.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
LGTM — Good fix for NameServer address inconsistency across brokers. The key improvement is the else branch in EnsureBrokerStatefulSets that detects when an existing StatefulSet's NAMESRV_ADDR env var differs from the current NameServersStr, triggering a broker update. The refactor into a separate method also improves readability.
Minor note: found.Spec.Template.Spec.Containers[0] is accessed without a bounds check, but this is safe given the operator always creates StatefulSets with at least one container.
Automated review by github-manager-bot
2 participants
